Fix accountability examples #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! @kevinmorio and I did some analysis. #595 introduced some code changes that make the integration tests fail: Annoyingly, we cannot reproduce this failure, neither on MacBook Pro 2019, Arch Linux, Debian 10 and Ubuntu 22.04, all with the same Maude that the integration test uses. Hence we cannot upload a file that stops this failure. This will block other PRs as well (sorry!). The onus on fixing this is on us. We think the best way to deal with this is to extend the github workflow with a way to download the artefacts, so we can debug this issue. |
kevinmorio
force-pushed
the
fix-accountability-examples
branch
from
91ab5bf
to
68a125a
Compare
Lelio-Brun
pushed a commit
to zt-iot/tamarin-prover
that referenced
this pull request
Apr 18, 2024
* Adapted some accountability examples to new SAPIC syntax. * Adapt another accountability example to updated SAPIC semantic * Add oracle heuristic to accountability examples * Adapt accountability examples from Master's thesis to new SAPiC semantic * Update README * Add README * Change to monospace * Add accountability case studies to regression tests * Revert failing case study to upstream version * Fix unintentional restore of failing case study --------- Co-authored-by: Robert Künnemann <robert.kuennemann@cispa.saarland> Co-authored-by: rkunnema <robert.kuennemann@cispa.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adapts the accountability examples to the new SAPiC semantic.
Moreover, it adds some accountability examples to the regression tests.