Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide row dendrogram axis ticks for plotly #307

Merged
merged 1 commit into from May 17, 2024

Conversation

siddharthab
Copy link
Contributor

To reproduce the issue, run:

heatmaply::heatmaply(mtcars, dendrogram = "row", plot_method = "plotly")

Notice that the row dendrogram has axis ticks at the bottom.

This issue is not present when plot_method is not plotly, or when dendrogram is not row. I have not looked into why this is the case.

To reproduce the issue, run:

```
heatmaply::heatmaply(mtcars, dendrogram = "row", plot_method = "plotly")
```

Notice that the row dendrogram has axis ticks at the bottom.
@talgalili
Copy link
Owner

Hi @siddharthab

Thanks, good catch!

For the record -

Here is how it looks to me (before applying your fix) with

heatmaply::heatmaply(mtcars, dendrogram = "row", plot_method = "plotly")

image

And with
heatmaply::heatmaply(mtcars, dendrogram = "row", plot_method = "ggplot")
image

And after the fix
heatmaply::heatmaply(mtcars, dendrogram = "row", plot_method = "plotly")

image

@talgalili talgalili merged commit 88e8474 into talgalili:master May 17, 2024
@talgalili talgalili requested review from talgalili and removed request for alanocallaghan May 17, 2024 17:20
@siddharthab siddharthab deleted the patch-1 branch May 17, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants