Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hmrHost and hmrPort to the ladle config #558

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

park-g
Copy link

@park-g park-g commented Apr 16, 2024

Fixes #557

Copy link

changeset-bot bot commented Apr 16, 2024

🦋 Changeset detected

Latest commit: 2eaa8a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
website Minor
@ladle/react Minor
example Patch
test-addons Patch
test-babel Patch
test-config Patch
test-config-ts Patch
test-css Patch
test-decorators Patch
test-playwright Patch
test-programmatic Patch
test-provider Patch
test-baseweb Patch
test-msw Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@park-g park-g force-pushed the allow-hmr-config-override branch from b12b9a3 to 2eaa8a4 Compare May 17, 2024 17:28
@park-g
Copy link
Author

park-g commented May 17, 2024

@tajo I found some time this evening to go through and tidy this up a bit and test it.

I think it should be ready to merge now if you wouldn't mind giving me a review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite HMR config does not override Ladle default config
1 participant