Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade react 18.3.1 from 18.2.0 #1412

Closed
wants to merge 1 commit into from
Closed

Upgrade react 18.3.1 from 18.2.0 #1412

wants to merge 1 commit into from

Conversation

shivam-sharma7
Copy link
Contributor

Upgrade react 18.3.1 from 18.2.0

@shivam-sharma7 shivam-sharma7 force-pushed the react-18.3.x branch 3 times, most recently from d0ef15d to 4c3f297 Compare April 27, 2024 14:30
@AvineshTripathi
Copy link
Collaborator

It released a few days before, I am not sure if we should shift directly cc @Azanul

@Azanul
Copy link
Collaborator

Azanul commented May 17, 2024

Dependency updates, like this one, are handled reliably by dependabot.

@Azanul Azanul closed this May 17, 2024
@shivam-sharma7 shivam-sharma7 deleted the react-18.3.x branch May 17, 2024 06:08
@shivam-sharma7 shivam-sharma7 restored the react-18.3.x branch May 17, 2024 06:09
@Azanul
Copy link
Collaborator

Azanul commented May 17, 2024

@Azanul But this upgrade was causing an error related CI I have fixed this and I belive dependabot not able to handle that

Could you link the failed CI run where this error occurred?

@Azanul
Copy link
Collaborator

Azanul commented May 17, 2024

@Azanul This is link-https://github.com/tailwarden/komiser/actions/runs/8860507652/job/24331359874#step:4:7

I know its small error but syncking lock file is very important!

Here's a successful CI run without the changes in this PR.
https://github.com/tailwarden/komiser/actions/runs/9125408769/job/25091527173?pr=1419

@shivam-sharma7
Copy link
Contributor Author

@Azanul Does that PR contains React 18.3..1? I think no, So what you want to tell me? check your PR file changes- https://github.com/tailwarden/komiser/pull/1419/files I'm not seeing anything related react.

@Azanul
Copy link
Collaborator

Azanul commented May 17, 2024

@Azanul Does that PR contains React 18.3..1? I think no, So what you want to tell me? check your PR file changes- https://github.com/tailwarden/komiser/pull/1419/files I'm not seeing anything related react.

It's not required. That's the point.

@shivam-sharma7 shivam-sharma7 deleted the react-18.3.x branch May 17, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlabouardy mlabouardy Awaiting requested review from mlabouardy mlabouardy is a code owner

@AvineshTripathi AvineshTripathi Awaiting requested review from AvineshTripathi AvineshTripathi is a code owner

@greghub greghub Awaiting requested review from greghub greghub is a code owner

@Azanul Azanul Awaiting requested review from Azanul Azanul is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shivam-sharma7 @AvineshTripathi @Azanul