Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grpc): map type support #1979

Merged
merged 28 commits into from
May 21, 2024
Merged

fix(grpc): map type support #1979

merged 28 commits into from
May 21, 2024

Conversation

meskill
Copy link
Contributor

@meskill meskill commented May 16, 2024

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #1911

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

meskill and others added 27 commits May 7, 2024 11:00
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Tushar Mathur <tusharmath@gmail.com>
Co-authored-by: Tushar Mathur <tusharmath@gmail.com>
@github-actions github-actions bot added the type: fix Iterations on existing features or infrastructure. label May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.24%. Comparing base (71e789e) to head (bc753c4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1979      +/-   ##
==========================================
+ Coverage   82.16%   82.24%   +0.08%     
==========================================
  Files         174      174              
  Lines       17716    17763      +47     
==========================================
+ Hits        14556    14609      +53     
+ Misses       3160     3154       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label May 18, 2024
@tusharmath tusharmath enabled auto-merge (squash) May 21, 2024 06:20
@tusharmath tusharmath merged commit 7c7633c into main May 21, 2024
26 checks passed
@tusharmath tusharmath deleted the fix/grpc-gen-map branch May 21, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(grpc): handle map types when generating config from protobuf
2 participants