fix: improvements #1937
Closed
fix: improvements #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: fix
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1937 +/- ##
==========================================
- Coverage 82.79% 82.76% -0.03%
==========================================
Files 183 183
Lines 18243 18251 +8
==========================================
+ Hits 15104 15106 +2
- Misses 3139 3145 +6 ☔ View full report in Codecov by Sentry. |
|
| Report | Sun, June 2, 2024 at 05:49:10 UTC |
| Project | tailcall |
| Branch | 1937/merge |
| Testbed | benchmarking-runner |
🚨 1 ALERT: Threshold Boundary Limit exceeded!
| Benchmark | Measure (units) | View | Value | Lower Boundary | Upper Boundary |
|---|---|---|---|---|---|
| input/value.missing | Latency (nanoseconds (ns)) | 🚨 (view plot | view alert) | 27.79 (+18.21%) | 25.27 (109.97%) |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|
| group_by | ✅ (view plot) | 537.26 (-8.40%) | 652.20 (82.38%) |
| input/args.missing | ✅ (view plot) | 23.02 (-5.63%) | 27.26 (84.45%) |
| input/args.nested.existing | ✅ (view plot) | 41.54 (-16.54%) | 64.84 (64.06%) |
| input/args.nested.missing | ✅ (view plot) | 37.38 (-2.40%) | 40.68 (91.90%) |
| input/args.root | ✅ (view plot) | 38.84 (-16.00%) | 61.60 (63.05%) |
| input/headers.existing | ✅ (view plot) | 30.23 (-4.71%) | 33.62 (89.92%) |
| input/headers.missing | ✅ (view plot) | 29.14 (-5.24%) | 33.49 (87.01%) |
| input/value.missing | 🚨 (view plot | view alert) | 27.79 (+18.21%) | 25.27 (109.97%) |
| input/value.nested.existing | ✅ (view plot) | 42.77 (+2.83%) | 44.94 (95.18%) |
| input/value.nested.missing | ✅ (view plot) | 35.50 (-2.69%) | 38.39 (92.47%) |
| input/value.root | ✅ (view plot) | 36.37 (-4.97%) | 41.60 (87.43%) |
| input/vars.existing | ✅ (view plot) | 7.42 (-7.42%) | 9.02 (82.32%) |
| input/vars.missing | ✅ (view plot) | 11.66 (+28.65%) | 12.11 (96.35%) |
| test_batched_body | ✅ (view plot) | 2,641.20 (-99.61%) | 2,415,494.90 (0.11%) |
| test_batched_body #2 | ✅ (view plot) | 1,659,100.00 (-3.34%) | 1,857,882.81 (89.30%) |
| test_data_loader | ✅ (view plot) | 467,800.00 (-0.55%) | 488,653.53 (95.73%) |
| test_handle_request | ✅ (view plot) | 152,540.00 (-5.30%) | 180,380.22 (84.57%) |
| test_http_execute_method | ✅ (view plot) | 18,402.00 (+0.26%) | 19,590.55 (93.93%) |
| with_mustache_expressions | ✅ (view plot) | 1,202.60 (+2.84%) | 1,234.75 (97.40%) |
| with_mustache_literal | ✅ (view plot) | 171.31 (-76.21%) | 816.05 (20.99%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
|
Moving this to draft. Can't see any significant change in performance from main. |
|
Action required: PR inactive for 2 days. |
github-actions
bot
added
state: inactive
|
Action required: PR inactive for 2 days. |
github-actions
bot
added
state: inactive
amitksingh1490
added
ci: benchmark
|
Action required: PR inactive for 2 days. |
github-actions
bot
added
state: inactive
|
Action required: PR inactive for 2 days. |
github-actions
bot
added
the
state: inactive
|
PR closed after 5 days of inactivity. |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: amit <amitksingh1490@gmail.com>
amitksingh1490
added
ci: benchmark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: parsing constant url at compile time (#1936)