-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Trezor Support #1205
base: main
Are you sure you want to change the base?
Add Trezor Support #1205
Conversation
20d119b
to
b4d0218
Compare
Hey @PabloCastellano, my 2 cents are:
I think if that would be forbidden to show right now then you wouldn't have it on your video showing up intermittently.
That would be appropriate but first its good enough to see something during onboarding flow! :)
For testing purposes you might experiment with hardwiring it into |
@fernya I have tried blocking the closing event but I haven't got anything useful. Also did some changes in the manifest.json file but nothing relevant, probably because I don't have so much experience with extensions development. Any advice is welcome! |
@PabloCastellano I would love to see this land in the extension 💪 But at the moment we are pretty much in churn mode for release and trezor is not on the requirement list for v1. I will gladly spend some time on debugging this issue :) |
@greg-nagy Yeah sure, no problem! Trezor support can wait for v2 😉 |
@PabloCastellano are you still interested in implementing Trezor support? Asking as we look to clean up stale PRs and figure out what's next. |
Hello!
Based on the Ledger implementation I am here drafting the Trezor implementation.
This is not working because the trezor popup is closed. My trezor is connected but I don't get prompted to enter my PIN. Any ideas?
out-2.mp4
Test it
Also add
HIDE_IMPORT_TREZOR=false
to your.env
.Open questions
TrezorConnect
in TrezorService instead?<script src="https://connect.trezor.io/8/trezor-connect.js"></script>
?TODO
Logs
console logs: