Candle indicators #1146
Draft
Candle indicators #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCookieLab
requested changes
May 9, 2024
|
|
||
| public class DownTrendIndicator extends AbstractIndicator<Boolean> { | ||
|
|
||
| private static final int UNSTABLE_BARS = 5; |
There was a problem hiding this comment.
The choice of 5 here is unnecessarily opinionated no? How about as a constructor param?
|
|
||
| public class UpTrendIndicator extends AbstractIndicator<Boolean> { | ||
|
|
||
| private static final int UNSTABLE_BARS = 5; |
| */ | ||
| public class HammerIndicator extends CachedIndicator<Boolean> { | ||
|
|
||
| private static final double BODY_LENGTH_TO_BOTTOM_WICK_COEFFICIENT = 2d; |
There was a problem hiding this comment.
Should these be constructor params rather than hardcoded?
| */ | ||
| public class HangingManIndicator extends CachedIndicator<Boolean> { | ||
|
|
||
| private static final double BODY_LENGTH_TO_BOTTOM_WICK_COEFFICIENT = 2d; |
There was a problem hiding this comment.
Same as above. Perhaps these values can be used as defaults in a no-arg constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1145.
Changes proposed in this pull request:
HammerIndicator
InvertedHammerIndicator
HangingManIndicator
DownTrendIndicator
UpTrendIndicator
added an entry with related ticket number(s) to the unreleased section of
CHANGES.md