Fix none major issues. #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 26 commits
December 7, 2022 15:24
…d_out error, it's best to put the socket.timeout above the OSError.
…works as intended. Essentially, if the core wasn't initialized within the first few milliseconds of startup, because of the way the while loop was constructed it would time out.
|
Why too many commits instead just three or the highest five? I saw you've committed to very few changes, especially typo and indentation stuff which can be specified in just one or two commits (if you want to split typos from indentation) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within this PR are primarily formatting fixes to follow the PEP8 styling code standards that python should follow.
Most notable is the syncing of tabs, to 4 spaces across all python files in the project.
Furthermore, I also fixed a logic bug within the method used to time out if the core doesn't initialise in time. Because of the way the, while loop was constructed, it would quit prior to the timeout being exceeded.
Some spelling mistakes were also fixed.