Update lab_prepare docker installation #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandrei279
requested changes
Nov 4, 2022
| sudo apt-get update | ||
| sudo apt-get install -y docker-ce docker-ce-cli containerd.io docker-compose | ||
| sudo apt-get upgrade | ||
| curl -fsSL test.docker.com -o get-docker.sh && sh get-docker.sh |
| sudo apt-get update | ||
| sudo apt-get install -y docker-ce docker-ce-cli containerd.io docker-compose | ||
| sudo apt-get upgrade | ||
| curl -fsSL test.docker.com -o get-docker.sh && sh get-docker.sh |
| sudo apt-get update | ||
| sudo apt-get install -y docker-ce docker-ce-cli containerd.io docker-compose | ||
| sudo apt-get upgrade | ||
| curl -fsSL test.docker.com -o get-docker.sh && sh get-docker.sh |
Co-authored-by: Andrei David <dandrei279@gmail.com>
Co-authored-by: Andrei David <dandrei279@gmail.com>
Co-authored-by: Andrei David <dandrei279@gmail.com>
dandrei279
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous script assumed that the arch was
amd64.This caused the setup to fail on
arm64machines.Replaced the steps with docker's script that does all the machinery in the back. [0]
Also, I added the current user to the
dockergroup so the user won't be required to usesudoeach time it interacts with docker.[0] - https://www.docker.com/blog/getting-started-with-docker-for-arm-on-linux/