Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkosi-initrd: Don't remove sanitizer libraries from initrd #2718

Merged
merged 1 commit into from
May 22, 2024

Conversation

DaanDeMeyer
Copy link
Contributor

Let's not unconditionally remove sanitizer libraries and their dependencies from the initrd as it turns out running software with sanitizers in the initrd isn't that far fetched.

Let's not unconditionally remove sanitizer libraries and their
dependencies from the initrd as it turns out running software with
sanitizers in the initrd isn't that far fetched.
@bluca
Copy link
Member

bluca commented May 20, 2024

FAILED tests/test_initrd.py::test_initrd_size - AssertionError: assert 635487...

Copy link
Contributor

@behrmann behrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI tests are expected, because CentOS changed a dependency a while ago, which blew up the initrd size. I'm rerunning the one Suse test, because I'm not sure what's the reason there.

@behrmann
Copy link
Contributor

Merging since Suse CI unborked itself and CentOS is known to have a too large initrd at the moment.

@behrmann behrmann merged commit f2b0932 into systemd:main May 22, 2024
27 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants