Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Better way to link to old docs at docs.sympy.org #19

Open
wants to merge 9 commits into
base: gh-pages
Choose a base branch
from

Conversation

mvnnn
Copy link

@mvnnn mvnnn commented Feb 29, 2016

@mvnnn
Copy link
Author

mvnnn commented Feb 29, 2016

@asmeurer that's working fine in all version except v 0.6.7 i get Access-Control-Allow-Origin' error.i hope that's working fine on server.

@asmeurer
Copy link
Member

What about the generate_indices script?

@asmeurer
Copy link
Member

I also see the issue with 0.6.7.

@asmeurer
Copy link
Member

As long as we're using Javascript can we make a popup menu? The only really important ones are latest and dev? Can we put those at the top of the popup, then a divider, then the rest of the versions?

@mvnnn
Copy link
Author

mvnnn commented Feb 29, 2016

The only really important ones are latest and dev? Can we put those at the top of the popup, then a divider, then the rest of the versions?

@asmeurer i am working on this.

@mvnnn
Copy link
Author

mvnnn commented Feb 29, 2016

I also see the issue with 0.6.7.

i read txt file from same Origin but still get Access-Control-Allow-Origin' error.i will try to solve that issue. i think that's jquery version problem.

@asmeurer
Copy link
Member

Regarding 0.6.7, I'm guessing there's a bug in your script, perhaps due to the fact that 0.6.7 is the first entry in the file.

@mvnnn
Copy link
Author

mvnnn commented Mar 1, 2016

@asmeurer i added this type of popup menu.
screenshot from 2016-03-01 14 51 06
when we click on Other.
screenshot from 2016-03-01 14 50 56

@mvnnn
Copy link
Author

mvnnn commented Mar 4, 2016

@asmeurer that's looks good ?

@asmeurer
Copy link
Member

asmeurer commented Mar 4, 2016

I would use a different color from yellow (see https://github.com/sympy/sympy-web-static#sympys-website-design for the pallet we use), but otherwise yes.

@mvnnn
Copy link
Author

mvnnn commented Mar 5, 2016

@asmeurer that's looks good ?
screenshot from 2016-03-05 14 39 43
screenshot from 2016-03-05 14 40 01

var res = elem.split(":");
if(res[0] == "0.7.6.1"){
$("#version-list").prepend("<li><a style='font-size:100%;' href="+"../latest/index.html"+"><span>Latest</span></a></li>");
}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asmeurer Need to update last line in releases.txt on your server.
0.7.6.1:SymPy 0.7.6.1 ---> latest:SymPy 0.7.6.1.in my code currently i set 0.7.6.1 take as a latest version if you update this file then i change my condition 0.7.6.1--> latest.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That file is generated automatically from the release script. Would it be possible to just check what the last value in the file is, and set that to "latest"?

@asmeurer
Copy link
Member

asmeurer commented Mar 8, 2016

@asmeurer that's looks good ?

Yes.

@mvnnn
Copy link
Author

mvnnn commented Mar 11, 2016

Would it be possible to just check what the last value in the file is, and set that to "latest"?

@asmeurer i added this condition and update my PR.

@asmeurer
Copy link
Member

It seems you've added jquery in multiple places.

@asmeurer
Copy link
Member

Is it possible to not duplicate popupmenu.css?

@asmeurer
Copy link
Member

We need to generate this automatically (update the generate_indexes.py script). When we release a new version, we should only have to run that script to fix everything. You can see what the release script runs here.

@asmeurer
Copy link
Member

In terms of the content, I would remove the "SymPy Versions" box. Instead just call the buttons "Latest version", "Development version", and "Other versions". Also, it seems to me that the versions in "other" should be sorted from latest to least latest (reverse of what it is now).

Finally, can it highlight the version that we are presently on, and if we are on a non-latest version, have the "other" box be open by default, with the version we are on highlighted.

@mvnnn
Copy link
Author

mvnnn commented Mar 29, 2016

@asmeurer Please check the changes.

@asmeurer
Copy link
Member

The pulsating "latest version" box is a bit confusing. It shows up when I mouse over an old version. Is that intentional?

Can we highlight for the current page (I guess use the lighter green).

@mvnnn
Copy link
Author

mvnnn commented Mar 29, 2016

screenshot from 2016-03-30 01 51 44
@asmeurer That's looks good ?

@asmeurer
Copy link
Member

That doesn't really indicate which version of the docs is currently active.

@mvnnn
Copy link
Author

mvnnn commented Mar 31, 2016

screenshot from 2016-03-31 11 16 52
screenshot from 2016-03-31 11 16 46
@asmeurer "latest version" background color is varies with time. now, that's looks good ? if not then explain little bit more which type of message box we need or sent me demo link .

@asmeurer
Copy link
Member

No, please don't add any annoying pulsating stuff. All I'm saying is that the version of the current page should be a different color, like this
screen shot 2016-03-31 at 3 18 22 pm

@mvnnn
Copy link
Author

mvnnn commented Mar 31, 2016

@asmeurer I like to add "latest" background color is varies with time. Should i do ?

@leosartaj
Copy link
Member

@asmeurer I like to add "latest" background color is varies with time. Should i do ?

IMO, background should be simple. I am -1 towards a "time varying" background color.

@mvnnn
Copy link
Author

mvnnn commented Mar 31, 2016

@asmeurer As we discuss about Docker container. I built my own docker container and then i transfer this on Sympy docker container. give me detail about which dependency you want to run on Docker container.

@mvnnn
Copy link
Author

mvnnn commented Apr 1, 2016

@asmeurer Please check the changes.

@asmeurer
Copy link
Member

asmeurer commented Apr 1, 2016

Doesn't seem to work. "Latest" is always highlighted, even when pages for other versions.

@mvnnn
Copy link
Author

mvnnn commented Apr 11, 2016

@asmeurer Sorry for delay, I added "latest" background color which is varies with time in Sympy 1.0 version.
screenshot from 2016-04-11 09 16 13
screenshot from 2016-04-11 09 16 14

@mvnnn
Copy link
Author

mvnnn commented Apr 19, 2016

@asmeurer That's looks good?

@certik
Copy link
Member

certik commented Apr 19, 2016

Thanks @mvnnn for working on this.

@mvnnn
Copy link
Author

mvnnn commented Apr 19, 2016

@certik if color looks not good then give me colors range.

@certik
Copy link
Member

certik commented Apr 19, 2016

The screenshots look pretty nice to me. @asmeurer any objections?

@mvnnn
Copy link
Author

mvnnn commented Apr 19, 2016

@asmeurer that's looks good then i add this color change in all other version also.

@asmeurer
Copy link
Member

Yes:

  • No pulsating colors please.
  • This doesn't do what it's supposed to do. It only highlights "latest". It should highlight the link for the page that you are on.

And finally, whatever design we agree on should be incorporated into the generate_indices script, so that it works for future versions automatically (or alternately, added to our docs stylesheet in the sympy repo).

@mvnnn
Copy link
Author

mvnnn commented Apr 20, 2016

Please check the changes.

@asmeurer
Copy link
Member

That looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants