Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified a check in _getitem_RepMatrix #26590

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

wermos
Copy link
Contributor

@wermos wermos commented May 11, 2024

References to other Issues or PRs

Brief description of what is fixed or changed

While investigating #26588, I noticed that there was a check that was awkwardly written. I simplified the check to make it easier to read and understand.

Other comments

Release Notes

NO ENTRY

@sympy-bot
Copy link

Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

  • No release notes entry will be added for this pull request.
Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed

While investigating #26588, I noticed that there was a check that was awkwardly written. I simplified the check to make it easier to read and understand.

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers. Formerly, `log(-x)` incorrectly gave `-log(x)`.

* physics.units
  * Corrected a semantical error in the conversion between volt and statvolt which
    reported the volt as being larger than the statvolt.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

@wermos wermos marked this pull request as draft May 11, 2024 07:44
Comment on lines 959 to +960
if (isinstance(i, Expr) and not i.is_number) or (isinstance(j, Expr) and not j.is_number):
if ((j < 0) is True) or ((j >= self.shape[1]) is True) or\
((i < 0) is True) or ((i >= self.shape[0]) is True):
if (j < 0) or (j >= self.shape[1]) or (i < 0) or (i >= self.shape[0]):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does not work for symbolic indices:

In [54]: i, j = symbols('i, j')

In [55]: M = Matrix([[1, 2], [3, 4]])

In [56]: M[i,j]
Out[56]: 
⎛⎡1  2⎤⎞      
⎜⎢    ⎥⎟[i, j]
⎝⎣3  4⎦⎠      

In [57]: M[i,j].subs({i:1,j:0})
Out[57]: 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants