Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added negative support for acos, asin #26542

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Gameboy612
Copy link

acos(-cos(x)) after simplify(..., inverse=True) fails to simplify to pi - x.

References to other Issues or PRs

Brief description of what is fixed or changed

Other comments

Release Notes

  • simplify
    • Corrected asin, acos not working in the case for negative numbers. Formerly, acos(-cos(x)) does not simplify to pi - x, asin(-sin(x)) does not simplify to -x. (This fix only applies to the inverse=True flag)

acos(-cos(x)) after simplify(..., inverse=True) fails to simplify to pi - x.
@sympy-bot
Copy link

Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • simplify
    • Corrected asin, acos not working in the case for negative numbers. Formerly, acos(-cos(x)) does not simplify to pi - x, asin(-sin(x)) does not simplify to -x. (This fix only applies to the inverse=True flag) (#26542 by @Gameboy612)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.13.

Click here to see the pull request description that was parsed.
acos(-cos(x)) after simplify(..., inverse=True) fails to simplify to pi - x.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers. Formerly, `log(-x)` incorrectly gave `-log(x)`.

* physics.units
  * Corrected a semantical error in the conversion between volt and statvolt which
    reported the volt as being larger than the statvolt.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* simplify
  * Corrected asin, acos not working in the case for negative numbers. Formerly, `acos(-cos(x))` does not simplify to `pi - x`, `asin(-sin(x))` does not simplify to -x. (This fix only applies to the inverse=True flag)
<!-- END RELEASE NOTES -->

Comment on lines 440 to +445
g = getattr(rv, 'inverse', None)
if isinstance(rv, asin):
x = rv.args[0]
if _coeff_isneg(x):
print(x.args)
return -f(x.args[1].args[0])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not check whether the argument is a sin function.

Also print should not be used.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll fix it when I'm back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants