Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the case of autolev parser #26441

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aquazod
Copy link

@aquazod aquazod commented Apr 2, 2024

Fixes #15166 & #16580

Brief description of what is fixed or changed

  • Added the parameter lower_case to the parse_autolev() function in the files: __init__.py, _parse_autolev_antlr.py, and test_autolev.py.
  • Removed the .lower() function from the _listener_autolev_antlr.py file as much as I could. Some .lower() functions had to stay there because they were either a key or a value in dictionaries.

Other comments

Can someone guide me to how to run the tests please

Release Notes

  • functions
    • added lower_case paramter to parse_autolev()

Thanks @NikhilPappu for the given tips previously.

@sympy-bot
Copy link

sympy-bot commented Apr 2, 2024

Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • functions

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.13.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->
Fixes [#15166](https://github.com/sympy/sympy/issues/15166) & [#16580 ](https://github.com/sympy/sympy/pull/16580)
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed

- Added the parameter `lower_case` to the `parse_autolev()` function in the files: `__init__.py`, `_parse_autolev_antlr.py`, and `test_autolev.py`.
- Removed the .lower() function from the `_listener_autolev_antlr.py` file as much as I could. Some `.lower()` functions had to stay there because they were either a key or a value in dictionaries. 

#### Other comments
Can someone guide me to how to run the tests please

#### Release Notes

<!-- BEGIN RELEASE NOTES -->
* functions
     * added `lower_case` paramter to `parse_autolev()`
<!-- END RELEASE NOTES -->
Thanks @NikhilPappu for the given tips previously.
<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't change the case of autolev variables
2 participants