Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-assign issues #73

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Auto-assign issues #73

wants to merge 16 commits into from

Conversation

asmeurer
Copy link
Member

@asmeurer asmeurer commented Nov 6, 2019

Fixes #72

Still a work in progress but the basic concept works. See asmeurer/GitHub-Issues-Test#43

@asmeurer asmeurer temporarily deployed to sympy-bot-testing November 7, 2019 00:18 Inactive
@asmeurer asmeurer temporarily deployed to sympy-bot-testing November 7, 2019 00:19 Inactive
@asmeurer asmeurer temporarily deployed to sympy-bot-testing November 7, 2019 00:23 Inactive
@asmeurer asmeurer temporarily deployed to sympy-bot-testing November 7, 2019 00:26 Inactive
@asmeurer
Copy link
Member Author

asmeurer commented Nov 7, 2019

This basically works the way I want it to. I just need to add tests and update the existing tests. But it would be good to get a concept review first to see if this is something we actually want to do.

@asmeurer
Copy link
Member Author

asmeurer commented Nov 7, 2019

OK, here's a snag. It looks like you can't actually assign people to an issue unless they are members of the organization. I know GitHub has had requests to change this, but it hasn't happened yet.

So we either need to sit on this until they do, or implement #68 (give all PR authors Triage permissions). #68 would have other advantages as well, and I think it wouldn't be too hard. One issue is that if a user is given Triage permissions, I don't know if you can assign them to issues right away or if they have to accept the invite first. If they have to accept the invite, then the bot wouldn't be able to assign them until some future PR event that occurs after they accept the invite (we could enable comment webhook updates if this is the case to get more pushes; we should still be fine for being under API limits I'd imagine).

@asmeurer
Copy link
Member Author

I guess you can assign anyone who has commented on the issue. That should cover most of the use cases. We can post a comment asking people to comment on the issue about the pull request if they haven't commented on the issue.

@asmeurer
Copy link
Member Author

GitHub now has a way to link issues without using "Fixes" but I don't see anything about it in the API.

@asmeurer
Copy link
Member Author

Might wait to see if they add it. It would make the logic here a lot simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assign the issue to the person who opened the pull request
1 participant