Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign the issue to the person who opened the pull request #72

Open
asmeurer opened this issue Nov 3, 2019 · 3 comments · May be fixed by #73
Open

Assign the issue to the person who opened the pull request #72

asmeurer opened this issue Nov 3, 2019 · 3 comments · May be fixed by #73

Comments

@asmeurer
Copy link
Member

asmeurer commented Nov 3, 2019

That way people can be more aware that the issue is already being worked on.

@asmeurer
Copy link
Member Author

asmeurer commented Nov 6, 2019

A minor issue: we can't easily unassign people if they remove a "fixes #123" from the pull request body or from a commit message (force push). Unless there's a way to notice this in the API that I'm not aware. Otherwise we've have to keep track of it somehow. It's not impossible (we could put it on the issue comment), but it would be more work. Presumably people can unassign themselves, though, so if they remove one they should be able to fix it.

We can easily unassign people if the PR is closed without merging.

@asmeurer asmeurer linked a pull request Nov 6, 2019 that will close this issue
@asmeurer
Copy link
Member Author

asmeurer commented Nov 6, 2019

A somewhat less minor issue: if someone unassigns themselves for whatever reason, the bot should be able to respect that and not reassign them on the next event. I'll need to see if this information is accessible in the API.

@asmeurer
Copy link
Member Author

asmeurer commented Nov 6, 2019

GitHub has just the API: https://developer.github.com/v3/issues/timeline/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant