Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added unknwon_visit #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

randolf-scholz
Copy link

@randolf-scholz randolf-scholz commented Apr 22, 2023

Fixes #34

@randolf-scholz
Copy link
Author

Ah, just now realized that my black-formatter automatically formatted the whole file. Should I revert that?

@asmeurer
Copy link
Member

Yes that would be good. If you know how to add a test that would be good too.

It looks like we're going to have to fix the CI. I guess we can drop Python 3.6 support.

@randolf-scholz
Copy link
Author

Python 3.7 is also EOL since Tuesday.

@asmeurer
Copy link
Member

Is this PR related to Python 3.7? Or is that just a comment on the CI? We can remove Python 3.6 and 3.7 from CI if they are failing.

@randolf-scholz
Copy link
Author

It's a comment about the CI, it seems to be broken. The first test failed with Error: Version 3.6 with arch x64 not found. The selection of python versions is outdated:

https://github.com/sympy/sphinx-math-dollar/blob/be629b9cc252dd478bd99592578a2a79731eb649/.github/workflows/pythonpackage.yml#L11-L12C7

        python-version: ['3.6', '3.7', '3.8', '3.9', '3.10', 'pypy-3.7',
                         'pypy-3.8', '3.11.0-alpha.2']

@asmeurer
Copy link
Member

The CI setup hasn't been touched in a while. It also still has Travis which doesn't work anymore. We'll need to update it. Shouldn't be much work as long as there aren't other issues that come up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unknown_visit to MathDollarReplacer
2 participants