detect wrong e-mail validation modes

symfony · Apr 27, 2024 · 8a2f9f7 · 8a2f9f7
1 parent f241871
commit 8a2f9f7
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/Constraints/Email.php b/Constraints/Email.php
@@ -62,6 +62,10 @@ public function __construct(
             throw new InvalidArgumentException('The "mode" parameter value is not valid.');
         }
 
+        if (null !== $mode && !\in_array($mode, self::$validationModes, true)) {
+            throw new InvalidArgumentException('The "mode" parameter value is not valid.');
+        }
+
         parent::__construct($options, $groups, $payload);
 
         $this->message = $message ?? $this->message;

diff --git a/Tests/Constraints/EmailTest.php b/Tests/Constraints/EmailTest.php
@@ -33,6 +33,13 @@ public function testUnknownModesTriggerException()
         new Email(['mode' => 'Unknown Mode']);
     }
 
+    public function testUnknownModeArgumentsTriggerException()
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('The "mode" parameter value is not valid.');
+        new Email(null, null, 'Unknown Mode');
+    }
+
     public function testNormalizerCanBeSet()
     {
         $email = new Email(['normalizer' => 'trim']);