[Live] Remove obsolete internal #1841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The component_url Twig function is not used since long time, is internal and unused, so this PR removes it. (i'm starting a little inventory of the code to see what is possible in term of separation between the components)
kbond
changed the title
|
Hmm, not sure about this. While the code to provide the twig function is internal, the twig function itself isn't internal and might be used. If I recall correctly, this function was added as a way to lazily load twig components with turbo. It might be used in the wild. I wonder though, now that we have true lazy components, is it still needed? Maybe we should deprecate and see? |
|
Oh i did not know that, i imagined it was some internal thing from the start. Let's close it then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
component_urlTwig function is not used (for a lot of time), is internal and.... unused.So this PR removes it.
(i'm starting a little inventory of the code to see what is possible in term of separation between the components)