Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed event data passing example #1829

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

manuelkiessling
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
License MIT

Looks like some obsolete data access approach via a $data array was still in the docs.

@carsonbot carsonbot added Bug Bug Fix Status: Needs Review Needs to be reviewed labels May 6, 2024
@@ -2728,18 +2728,18 @@ You can also pass extra (scalar) data to the listeners::
// ...

$this->emit('productAdded', [
'product' => $product->getId(),
'productId' => $product->getId(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will make the Product entity example (L2745-2752) not working :|

@smnandre smnandre added LiveComponent documentation Improvements or additions to documentation and removed Bug Bug Fix labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation LiveComponent Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants