[TwigComponent] refactor debug:twig-component/TwigComponentDataCollector
#1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
force-pushed
the
live/debug-command-and-profiler
branch
from
419e3f8
to
52ba3b3
Compare
smnandre
reviewed
Apr 30, 2024
Comment on lines
+72
to
+73
| if ($name = $input->getArgument('name')) { | ||
| if (!$component = $this->findComponentName($io, $name, $input->isInteractive())) { |
There was a problem hiding this comment.
Maybe even put this in "interact" ?
smnandre
reviewed
Apr 30, 2024
Comment on lines
+260
to
+263
| match (true) { | ||
| null === $metadata->get('class') => '<comment>Anon</comment>', | ||
| $metadata->get('live') => '<info>Live</info>', | ||
| default => '', |
smnandre
reviewed
Apr 30, 2024
| $container->setAlias('console.command.stimulus_component_debug', 'ux.twig_component.command.debug') | ||
| ->setDeprecated('symfony/ux-twig-component', '2.13', '%alias_id%'); | ||
|
|
||
| if ($container->getParameter('kernel.debug')) { | ||
| $loader->load('debug.php'); | ||
|
|
||
| $container->setParameter('ux.twig_component.anonymous_template_directory', $config['anonymous_template_directory']); |
There was a problem hiding this comment.
Not sure to understand why we need this ?
i'd rather not set container parameters (even in debug only) if we can avoid
There was a problem hiding this comment.
Not sure to understand why we need this ?
This was a relic from the previous PR. I think I can remove.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successor to #1722.
debug:twig-commandto allow [LiveComponent] Add Events listening infos in Profiler and DebugCommand #1720TwigComponentDataCollectorto allow [LiveComponent] Add Events listening infos in Profiler and DebugCommand #1720