Update homepage.html.twig #1682
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smnandre
reviewed
Apr 5, 2024
| @@ -71,7 +71,7 @@ | |||
| </div> | |||
| <div class="col-12 col-md-6 mt-3 mt-md-0"> | |||
| <twig:CodeBlock | |||
| filename="assets/controllers/markdown-controller.js" | |||
| filename="assets/controllers/markdown_controller.js" | |||
There was a problem hiding this comment.
I think today we used "-controller" as naming convention..
Not sure we should change for only one :|
There was a problem hiding this comment.
What about renaming then the hello-controller?
There was a problem hiding this comment.
If you think that'll improve the coherence yes for sure!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following previous PR, with the bloc showcasing hello_controller.js, direct after seeing markdown-controller.js seems not logic (even if stimulus under the hood is ok for both identifiers)