Update RecipeFileTree.php #1681
Conversation
| ->addFile('package.json', 'Holds your node dependencies, most importantly Stimulus & Webpack Encore.') | ||
| ->addFile('webpack.config.js', 'Configuration file for Webpack Encore: the tool that processes and combines all of your CSS and JS files.') | ||
| ->addFile('package.json', 'Holds your node dependencies, most importantly Stimulus (when using Webpack Encore).') | ||
| ->addFile('webpack.config.js', 'Configuration file for Webpack Encore: the tool that processes and combines all of your CSS and JS files (not needed with AssetMapper).') |
There was a problem hiding this comment.
We will support webpack encore, but i don't think we want to showcase it in the "default case", as it won't be there for people installing a new Symfony webapp.
So those two files could probably be explained on the documentation, but right there it's kinda the opposite of what we're trying to promote for easy plug-n-play DX.
WDYT ?
There was a problem hiding this comment.
you mean those can be removed completely ?
Why not, and somewhere else document that such file may exists if webpack encore is still use in the app
There was a problem hiding this comment.
I mean.. it's kinda odd to brand "assetmapper" as "no-npm-tools" and showcase them here, right ? So maybe we can do the jumb.
Another idea would be to have some tabbed content here with "assetmapper / webpack" but i feel on this place, maybe we should be the most direct/simple we can.
such texts are display on hover on homepage
I think it is relevant to at least document that such files are optional sometime aka with assetmapper