Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TwigComponent] Render in PostRenderEvent #1536

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from

Conversation

smnandre
Copy link
Collaborator

Q A
Bug fix? no
New feature? yes
License MIT

Pass the rendered content in the Event
(not available for the embedded components)

Similar to what's done in HttpFramework with the ResponseEvent

Pass the rendered content in the Event
(not available for the `embedded` components)
@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Feb 22, 2024
@kbond
Copy link
Member

kbond commented Feb 22, 2024

Can you show a use-case for this? Would this help with what we do in #1450?

@smnandre
Copy link
Collaborator Author

smnandre commented Feb 22, 2024

For a single icon i don't think so... as we bypass the component system to call a function directly.

For the website yes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants