[Autocomplete] Reset TomSelect when updating controller attributes #1505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using remote data for Autocomplete, the mutation observer is not started, so the select cannot be reset when some options change (E.G when limiting the options returned after selecting other options using extra_options from #1322).
Instead, we start the mutation observer when using remote data. When the observer runs and checks if the options have changes, we explicitly set the
areOptionsEquivalent
totrue
, since the page will just render an emptyselect
. We also check if any of thedata-autocomplete
attributes changes and forces a reset (E.G using extra_options, thedata-autocomplete-url
value can be different when using extra options, so we reset the select when this attribute changes).This fixes only one of the issues from #1500, I'll investigate the other issues and create separate PRs.