Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] IBAN Check digits should always between 2 and 98 #54924

Merged
merged 1 commit into from
May 16, 2024

Conversation

karstennilsen
Copy link
Contributor

@karstennilsen karstennilsen commented May 14, 2024

Q A
Branch? 5.4
Bug fix? yes/no
New feature? no
Deprecations? no
Issues No existing
License MIT

A ECBS document (https://www.ecbs.org/Download/EBS204_V3.PDF) replicates part of the ISO/IEC 7064:2003 standard as a method for generating check digits in the range 02 to 98.

Besides this I have a production database of 160K valid IBANs. All of them have a check digit between 02 and 98.

Example of invalid IBANs, which before were valid, are NL01INGB0001393698 and NL01RABO0331811235. You can check them at iban.com to verify they are indeed invalid.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@karstennilsen
Copy link
Contributor Author

7.2 & 8.0 integration & 8.2 unit test failures seem to be non related to changes in this PR

@nicolas-grekas
Copy link
Member

Thank you @karstennilsen.

@nicolas-grekas nicolas-grekas merged commit a8a31e6 into symfony:5.4 May 16, 2024
7 of 12 checks passed
@fabpot fabpot mentioned this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants