Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PasswordHasher] fix tests #54918

Merged
merged 1 commit into from
May 14, 2024
Merged

[PasswordHasher] fix tests #54918

merged 1 commit into from
May 14, 2024
+2 −2

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented May 14, 2024

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

@xabbuh xabbuh requested a review from chalasr as a code owner May 14, 2024 07:07
@carsonbot carsonbot added this to the 5.4 milestone May 14, 2024
@xabbuh
Copy link
Member Author

xabbuh commented May 14, 2024

see

symfony/src/Symfony/Component/PasswordHasher/Tests/Hasher/NativePasswordHasherTest.php

Line 108 in fbc47bc

$this->assertFalse($hasher->verify(password_hash($plainPassword, \PASSWORD_BCRYPT, ['cost' => 4]), $plainPassword));
(this is how the assertion was before #54858)

alexandre-daubois
alexandre-daubois approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@alexandre-daubois alexandre-daubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xabbuh xabbuh merged commit 84f0b88 into symfony:5.4 May 14, 2024
8 of 12 checks passed
@xabbuh xabbuh deleted the appveyor-password-hasher-tests branch May 14, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandre-daubois alexandre-daubois alexandre-daubois approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
PasswordHasher Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xabbuh @alexandre-daubois @carsonbot