[HttpClient] Implemented LoggerAwareInterface in HttpClientInterface decorators #54668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann-eugone
changed the title
|
Can you please do the same for all decorators? I see that others could need that change. |
1 similar comment
|
Can you please do the same for all decorators? I see that others could need that change. |
|
@nicolas-grekas sure, just did : 7f2fe9b |
nicolas-grekas
approved these changes
Apr 19, 2024
derrabus
approved these changes
Apr 19, 2024
yann-eugone
changed the title
nicolas-grekas
force-pushed
the
logger-aware-uri-template-http-client
branch
from
7f2fe9b
to
c2a7b73
Compare
|
Thank you @yann-eugone. |
|
Happy to help 🙂 |
|
Reverted in #54674 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
Psr\Log\LoggerAwareInterfaceinSymfony\Component\HttpClient\UriTemplateHttpClient.I was on a journey to enhance our logs on a project that highly depend on
HttpClient.I started to separate logs per feature, and I wanted to include
HttpClientlogs to the logger of the currently running the feature.I figured out that most implementations of
HttpClientInterfaceare implementingLoggerAwareInterface, so I decided to just call$client->setLogger(...)on my side.And nothing changed.
Nothing changed because my logger is decorated by the
UriTemplateHttpClientthat is not implementingLoggerAwareInterface.Althought
UriTemplateHttpClienthas no need of a logger, as a decorator it should be able to act like it, so the underlying client can be reached.This is what is done for instance in
Symfony\Component\HttpClient\TraceableHttpClient.