Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HttpFoundation] defer addition of new method argument to 8.0 #54528

Merged
merged 1 commit into from Apr 9, 2024
Merged

[HttpFoundation] defer addition of new method argument to 8.0 #54528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/Symfony/Component/HttpFoundation/UriSigner.php
View file
Open in desktop
Expand Up @@ -51,8 +51,18 @@ public function __construct(#[\SensitiveParameter] string $secret, string $hashP
*
* The expiration is added as a query string parameter.
*/
public function sign(string $uri, \DateTimeInterface|\DateInterval|int|null $expiration = null): string
public function sign(string $uri/*, \DateTimeInterface|\DateInterval|int|null $expiration = null*/): string
{
$expiration = null;

if (1 < \func_num_args()) {
$expiration = func_get_arg(1);
}

if (null !== $expiration && !$expiration instanceof \DateTimeInterface && !$expiration instanceof \DateInterval && !\is_int($expiration)) {
throw new \TypeError(sprintf('The second argument of %s() must be an instance of %s or %s, an integer or null (%s given).', __METHOD__, \DateTimeInterface::class, \DateInterval::class, get_debug_type($expiration)));
}

$url = parse_url($uri);
$params = [];

Expand Down