[WebProfilerBundle] [WebProfilerPanel] Update the design of the workflow profiler panel #54364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
stof
reviewed
Mar 21, 2024
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/workflow.html.twig
Outdated
Show resolved
Hide resolved
chalasr
approved these changes
Mar 22, 2024
fabpot
approved these changes
Mar 23, 2024
…low profiler panel
|
Thank you @javiereguiluz. |
fabpot
force-pushed
the
workflow_profiler
branch
from
4dfd63d
to
6297faa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Workflow profiler panel is very nice, but I think it has some design issues, mostly on dark mode. This PR proposes some changes:
I don't have before/after screenshots, but this PR also fixes the design of the dialog that opens when you click on any node.
There's other obvious issue which is that the SVG diagram overflows the page. I looked into JS libraries such as https://github.com/anvaka/panzoom and https://github.com/bumbu/svg-pan-zoom to add a "pan + zoom" utility ... but for now I think this would be worse. A full-size overflown diagram is more productive to quickly find issues.