Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecurityBundle] Use "event" monolog channel in traceable firewall event dispatcher #54032

Merged

Conversation

danielburger1337
Copy link
Contributor

@danielburger1337 danielburger1337 commented Feb 22, 2024

Q A
Branch? 7.1
Bug fix? yes
New feature? no
Deprecations? no
Issues n/a
License MIT

I think since #49021 was merged, security events in debug mode are logged inside the "app" (default) channel.

This is very annoying in an API use case as every request generates about 10 useless log entries.

This PR changes the monolog channel of the traceable event dispatcher to event and also tags it with kernel.reset. This matches the behavior of debug.event_dispatcher.

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "7.1 or 7.0".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@fabpot fabpot force-pushed the traceable-firewall-eventdispatcher branch from 575b929 to 3995c71 Compare March 17, 2024 15:08
@fabpot
Copy link
Member

fabpot commented Mar 17, 2024

Thank you @danielburger1337.

@fabpot fabpot merged commit 394d6b4 into symfony:7.1 Mar 17, 2024
4 of 6 checks passed
@danielburger1337 danielburger1337 deleted the traceable-firewall-eventdispatcher branch March 17, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants