Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mailer] [Amazon] Add support for X-SES-LIST-MANAGEMENT-OPTIONS header #53901

Merged
merged 1 commit into from Mar 17, 2024

Conversation

sebschaefer
Copy link
Contributor

@sebschaefer sebschaefer commented Feb 11, 2024

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
License MIT

Add Support for AWS SES List Management Feature
SES will provide the following features:

Use:

  • follow the AWS instructions to create a contact list
  • optional: add a topic to the list
  • RawMessage->addTextHeader('X-SES-LIST-MANAGEMENT-OPTIONS','contactListName=MyListName;topicName=MyNewsletter')

@carsonbot
Copy link

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

@Nyholm
Copy link
Member

Nyholm commented Feb 12, 2024

Lovely. Thank you. This is indeed a good feature.

Could you add some tests too?

@sebschaefer
Copy link
Contributor Author

I've added two tests. Thank you.

@fabpot
Copy link
Member

fabpot commented Mar 17, 2024

Thank you @sebschaefer.

@fabpot fabpot merged commit c0ecee0 into symfony:7.1 Mar 17, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants