minor #54388 [Filesystem] use local PHP web server to test HTTP strea…

…m wrappers (xabbuh)

This PR was merged into the 5.4 branch.

Discussion
----------

[Filesystem] use local PHP web server to test HTTP stream wrappers

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

same approach as #54360 (see https://github.com/symfony/symfony/actions/runs/8387183697/job/22968895866#step:8:2558 for a failure)

Commits
-------

8a7813b use local PHP web server to test HTTP stream wrappers

src/Symfony/Component/Filesystem/Tests/FilesystemTest.php

@@ -14,6 +14,8 @@
 use Symfony\Component\Filesystem\Exception\InvalidArgumentException;
 use Symfony\Component\Filesystem\Exception\IOException;
 use Symfony\Component\Filesystem\Path;
+use Symfony\Component\Process\PhpExecutableFinder;
+use Symfony\Component\Process\Process;
 
 /**
  * Test class for Filesystem.
@@ -162,23 +164,32 @@ public function testCopyCreatesTargetDirectoryIfItDoesNotExist()
         $this->assertStringEqualsFile($targetFilePath, 'SOURCE FILE');
     }
 
-    /**
-     * @group network
-     */
     public function testCopyForOriginUrlsAndExistingLocalFileDefaultsToCopy()
     {
-        if (!\in_array('https', stream_get_wrappers())) {
-            $this->markTestSkipped('"https" stream wrapper is not enabled.');
+        if (!\in_array('http', stream_get_wrappers())) {
+            $this->markTestSkipped('"http" stream wrapper is not enabled.');
         }
-        $sourceFilePath = 'https://symfony.com/images/common/logo/logo_symfony_header.png';
-        $targetFilePath = $this->workspace.\DIRECTORY_SEPARATOR.'copy_target_file';
 
-        file_put_contents($targetFilePath, 'TARGET FILE');
+        $finder = new PhpExecutableFinder();
+        $process = new Process(array_merge([$finder->find(false)], $finder->findArguments(), ['-dopcache.enable=0', '-dvariables_order=EGPCS', '-S', '127.0.0.1:8057']));
+        $process->setWorkingDirectory(__DIR__.'/Fixtures/web');
 
-        $this->filesystem->copy($sourceFilePath, $targetFilePath, false);
+        $process->start();
 
-        $this->assertFileExists($targetFilePath);
-        $this->assertEquals(file_get_contents($sourceFilePath), file_get_contents($targetFilePath));
+        do {
+            usleep(50000);
+        } while (!@fopen('http://127.0.0.1:8057', 'r'));
+
+        try {
+            $sourceFilePath = 'http://localhost:8057/logo_symfony_header.png';
+            $targetFilePath = $this->workspace.\DIRECTORY_SEPARATOR.'copy_target_file';
+            file_put_contents($targetFilePath, 'TARGET FILE');
+            $this->filesystem->copy($sourceFilePath, $targetFilePath, false);
+            $this->assertFileExists($targetFilePath);
+            $this->assertEquals(file_get_contents($sourceFilePath), file_get_contents($targetFilePath));
+        } finally {
+            $process->stop();
+        }
     }
 
     public function testMkdirCreatesDirectoriesRecursively()

src/Symfony/Component/Filesystem/Tests/Fixtures/web/index.php

@@ -0,0 +1 @@
+<?php

src/Symfony/Component/Filesystem/composer.json

@@ -19,7 +19,8 @@
         "php": ">=7.2.5",
         "symfony/polyfill-ctype": "~1.8",
         "symfony/polyfill-mbstring": "~1.8",
-        "symfony/polyfill-php80": "^1.16"
+        "symfony/polyfill-php80": "^1.16",
+        "symfony/process": "^5.4|^6.4"
     },
     "autoload": {
         "psr-4": { "Symfony\\Component\\Filesystem\\": "" },

src/Symfony/Component/Mime/Tests/Part/DataPartTest.php

@@ -138,32 +138,35 @@ public function testFromPathWithNotAFile()
 
     public function testFromPathWithUrl()
     {
-        if (!\in_array('https', stream_get_wrappers())) {
-            $this->markTestSkipped('"https" stream wrapper is not enabled.');
+        if (!\in_array('http', stream_get_wrappers())) {
+            $this->markTestSkipped('"http" stream wrapper is not enabled.');
         }
 
         $finder = new PhpExecutableFinder();
         $process = new Process(array_merge([$finder->find(false)], $finder->findArguments(), ['-dopcache.enable=0', '-dvariables_order=EGPCS', '-S', '127.0.0.1:8057']));
         $process->setWorkingDirectory(__DIR__.'/../Fixtures/web');
         $process->start();
 
-        do {
-            usleep(50000);
-        } while (!@fopen('http://127.0.0.1:8057', 'r'));
-
-        $p = DataPart::fromPath($file = 'http://localhost:8057/logo_symfony_header.png');
-        $content = file_get_contents($file);
-        $this->assertEquals($content, $p->getBody());
-        $maxLineLength = 76;
-        $this->assertEquals(substr(base64_encode($content), 0, $maxLineLength), substr($p->bodyToString(), 0, $maxLineLength));
-        $this->assertEquals(substr(base64_encode($content), 0, $maxLineLength), substr(implode('', iterator_to_array($p->bodyToIterable())), 0, $maxLineLength));
-        $this->assertEquals('image', $p->getMediaType());
-        $this->assertEquals('png', $p->getMediaSubType());
-        $this->assertEquals(new Headers(
-            new ParameterizedHeader('Content-Type', 'image/png', ['name' => 'logo_symfony_header.png']),
-            new UnstructuredHeader('Content-Transfer-Encoding', 'base64'),
-            new ParameterizedHeader('Content-Disposition', 'attachment', ['name' => 'logo_symfony_header.png', 'filename' => 'logo_symfony_header.png'])
-        ), $p->getPreparedHeaders());
+        try {
+            do {
+                usleep(50000);
+            } while (!@fopen('http://127.0.0.1:8057', 'r'));
+            $p = DataPart::fromPath($file = 'http://localhost:8057/logo_symfony_header.png');
+            $content = file_get_contents($file);
+            $this->assertEquals($content, $p->getBody());
+            $maxLineLength = 76;
+            $this->assertEquals(substr(base64_encode($content), 0, $maxLineLength), substr($p->bodyToString(), 0, $maxLineLength));
+            $this->assertEquals(substr(base64_encode($content), 0, $maxLineLength), substr(implode('', iterator_to_array($p->bodyToIterable())), 0, $maxLineLength));
+            $this->assertEquals('image', $p->getMediaType());
+            $this->assertEquals('png', $p->getMediaSubType());
+            $this->assertEquals(new Headers(
+                new ParameterizedHeader('Content-Type', 'image/png', ['name' => 'logo_symfony_header.png']),
+                new UnstructuredHeader('Content-Transfer-Encoding', 'base64'),
+                new ParameterizedHeader('Content-Disposition', 'attachment', ['name' => 'logo_symfony_header.png', 'filename' => 'logo_symfony_header.png'])
+            ), $p->getPreparedHeaders());
+        } finally {
+            $process->stop();
+        }
     }
 
     public function testHasContentId()