Build response header manually

symfony · Feb 4, 2024 · 7d0265c · 7d0265c
1 parent 0b4a584
commit 7d0265c
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 13 deletions.
diff --git a/src/Symfony/Component/HttpFoundation/Response.php b/src/Symfony/Component/HttpFoundation/Response.php
@@ -217,7 +217,7 @@ public function __construct(?string $content = '', int $status = 200, array $hea
     public function __toString(): string
     {
         return
-            $this->getCommandString()."\r\n".
+            sprintf('HTTP/%s %s %s', $this->version, $this->statusCode, $this->statusText)."\r\n".
             $this->headers."\r\n".
             $this->getContent();
     }
@@ -230,14 +230,6 @@ public function __clone()
         $this->headers = clone $this->headers;
     }
 
-    /**
-     * @return string The first line of the actual HTTP request
-     */
-    public function getCommandString(): string
-    {
-        return sprintf('HTTP/%s %s %s', $this->version, $this->statusCode, $this->statusText);
-    }
-
     /**
      * Prepares the Response before it is sent to the client.
      *

diff --git a/src/Symfony/Component/HttpFoundation/Test/Constraint/ResponseIsRedirected.php b/src/Symfony/Component/HttpFoundation/Test/Constraint/ResponseIsRedirected.php
@@ -49,7 +49,7 @@ protected function additionalFailureDescription($other): string
         if ($this->verbose || !($other instanceof Response)) {
             return (string) $other;
         } else {
-            return $other->getCommandString()."\r\n".$other->headers;
+            return explode("\r\n\r\n", (string) $other)[0];
         }
     }
 }
diff --git a/src/Symfony/Component/HttpFoundation/Test/Constraint/ResponseIsSuccessful.php b/src/Symfony/Component/HttpFoundation/Test/Constraint/ResponseIsSuccessful.php
@@ -49,7 +49,7 @@ protected function additionalFailureDescription($other): string
         if ($this->verbose || !($other instanceof Response)) {
             return (string) $other;
         } else {
-            return $other->getCommandString()."\r\n".$other->headers;
+            return explode("\r\n\r\n", (string) $other)[0];
         }
     }
 }
diff --git a/src/Symfony/Component/HttpFoundation/Test/Constraint/ResponseIsUnprocessable.php b/src/Symfony/Component/HttpFoundation/Test/Constraint/ResponseIsUnprocessable.php
@@ -49,7 +49,7 @@ protected function additionalFailureDescription($other): string
         if ($this->verbose || !($other instanceof Response)) {
             return (string) $other;
         } else {
-            return $other->getCommandString()."\r\n".$other->headers;
+            return explode("\r\n\r\n", (string) $other)[0];
         }
     }
 }
diff --git a/src/Symfony/Component/HttpFoundation/Test/Constraint/ResponseStatusCodeSame.php b/src/Symfony/Component/HttpFoundation/Test/Constraint/ResponseStatusCodeSame.php
@@ -49,7 +49,7 @@ protected function additionalFailureDescription($other): string
         if ($this->verbose || !($other instanceof Response)) {
             return (string) $other;
         } else {
-            return $other->getCommandString()."\r\n".$other->headers;
+            return explode("\r\n\r\n", (string) $other)[0];
         }
     }
 }