Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit Messenger bus configuration #1298

Merged

Conversation

priyadi
Copy link
Contributor

@priyadi priyadi commented Mar 9, 2024

Q A
License MIT
Doc issue/PR

Make bus configuration in messenger.yaml explicit to facilitate third-party bundles providing their bus configuration.

Without this configuration, if a bundle provides a bus configuration via a flex recipe, it silently becomes the default bus. Or if there is already a bus configuration, but without the default_bus setting, it will give us "Invalid configuration for path "framework.messenger": You must specify the "default_bus" if you define more than one bus."

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) March 9, 2024 11:38
Copy link

github-actions bot commented Mar 9, 2024

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1298/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1298/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'symfony/webapp-pack:^1.0'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

@symfony-recipes-bot symfony-recipes-bot merged commit 88999ac into symfony:main Mar 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants