Add Mbstring::assertEncoding() #474
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebase welcome now that #466 is merged. |
zonuexe
force-pushed
the
refactor/assertEncoding
branch
from
c250b12
to
f5abc49
Compare
|
@nicolas-grekas Thanks, I applied this method to other methods as well and pushed it. |
nicolas-grekas
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same pattern of encoding checks is required in another method, so you can separate encoding assertions and avoid copy-pasting.
refs https://github.com/symfony/polyfill/pull/466/files#r1545573878 Cc: @Ayesh