New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHP 8.4] Add mb_ucfirst() and mb_lcfirst() #471
Conversation
d75bb6b
to
86116b5
Compare
7bfc6b7
to
3cef459
Compare
3cef459
to
b10bf3c
Compare
These errors below looks strange:
Internal functions up to PHP 8.0 implicitly accepted polyfill/src/Util/TestListenerTrait.php Lines 126 to 136 in df4793d
In the code below, PHP 8.4 deprecates implicit nullable, so this test should be replaced with more stringent checks. |
@@ -105,7 +105,7 @@ public function testDecodeNumericEntity() | |||
$this->assertSame('déjà � â ã', mb_decode_numericentity('déjà � á â', $convmap, 'UTF-8')); | |||
|
|||
$bogusDecEntities = 'déjà � áá &#áá á át'; | |||
$this->assertSame('déjà � ââ &#áâ â ât', mb_decode_numericentity($bogusDecEntities, $convmap, 'UTF-8')); | |||
$this->assertSame('déjà � ââ &#áâ â ât', p::mb_decode_numericentity($bogusDecEntities, $convmap, 'UTF-8')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test was affected by changes in the native mb_decode_numericentity()
function.
It seems that other tests also need to call polyfill methods instead of built-in function.
Possibly duplicate of #466 |
@Ayesh Sorry, I missed that PR because the issue didn't exist. It looks like my patch is covered by your implementation. |
Let's put the efforts together :) |
resolve #470
This implementation is also tested and benchmarked in my repository: https://github.com/zonuexe/polyfill-mb_ulcfirst