New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[make:security] Add throttling support to authenticator maker #1524
base: main
Are you sure you want to change the base?
Conversation
3897b2d
to
239554d
Compare
In the MakeAuthenticator class, a new optional argument 'support-throttling' was added. This allows the user to specify if they want to enable throttling protection during the authentication generation process. If 'support-throttling' is enabled, the LimiterInterface dependency is added and the 'throttling' node is set in the firewall configuration.
@@ -209,6 +210,15 @@ function ($answer) { | |||
$supportRememberMeValues[$supportRememberMeType] | |||
); | |||
} | |||
|
|||
$command->addArgument('support-throttling', InputArgument::OPTIONAL); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MakeAuthenticator
is being deprecated - we are not adding any new features to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Howdy @Spomky
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Howdy @Spomky - Sorry for the double review... Coffee has not kicked in yet...
Anywho, as I said in #1406 (comment) make:auth
is being deprecated in favor of the make:security:form-login
command. We are not adding any new features to make:auth
at this time.
Reopening #1406
In the MakeAuthenticator class, a new optional argument 'support-throttling' was added. This allows the user to specify if they want to enable throttling protection during the authentication generation process. If 'support-throttling' is enabled, the LimiterInterface dependency is added and the 'throttling' node is set in the firewall configuration.