Add cascade annotation option support in ClassSourceManipulator #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
reviewed
Jul 10, 2023
| }, | ||
| "require-dev": { | ||
| "composer/semver": "^3.0", | ||
| "dbrekelmans/bdi": "dev-main", |
There was a problem hiding this comment.
Are any of these changes necessary?
| @@ -11,7 +11,7 @@ | |||
| > | |||
| <php> | |||
| <ini name="error_reporting" value="-1" /> | |||
| <env name="TEST_DATABASE_DSN" value="mysql://root:root@127.0.0.1:3306/test_maker?serverVersion=5.7" /> | |||
| <env name="TEST_DATABASE_DSN" value="mysql://root:root@mariadb:3306/test_maker?serverVersion=5.7" /> | |||
trislem
force-pushed
the
add-cascade-option
branch
from
7c4fcef
to
aacb253
Compare
weaverryan
reviewed
Jul 31, 2023
| isNullable: true, | ||
| cascade: ['persist'], | ||
| ), | ||
| ]; |
There was a problem hiding this comment.
Let's remove the many_to_many and one_to_one test cases. It's enough to make sure that a "singular" and "collection" relationship are tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow adding the cascade annotation option for OneToMany, ManyToOne and ManyToMany relation in ClassSourceManipulator.
The OneToOne remains forced to ['persist', 'remove']
Related issue : #1316