Allow to manipulate traits #1319
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trislem
force-pushed
the
allow-manipulate-trait
branch
from
02bd9fb
to
9dd8c16
Compare
|
Hey @trislem, Could you provide any use-case for this change? Thanks, Cheers! |
|
oh sorry, now I see the issue, as an advice for the future, in PR description always put a link to issue you are trying to solve in PR, then it will be easier to see what and why :) |
Hi, I opened an issue to ask for some opinions. Should I make one issue per pull request right now ? |
|
no it's not necessary, it will be ok just link your issue in description, or you can link your PR's in the issue each one at line which describes the problem ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the possibility to also manipulate traits instead of just classes*
Related issue : #1316