Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 (kernel) when configuring the container add services with php extension #37

Conversation

helyakin
Copy link

Hello the community

This is my first PR attempt.

So after reading this documentation and unsuccessfully trying to load my service_test.php, I've noticed that the configureContainer(..) function in the MicroKernelTrait file was not configured to automatically load this file.

So either we should fix the documentation, either we should fix the configuration.

Since this package is backed by Alximy I figured it would be cool 馃槑 to try and fix 馃悰 the configuration.

Anyway share me your thoughts about what should be done !

And I wanted to say that php service configuration is 馃敟 so shoutout to the one who did this (I think it's you @nicolas-grekas with this PR right ? 馃挭馃徎)

Also big thanks to @jeremyFreeAgent for debugging this with me and @HeahDude for showing me the php service configuration PR.

@github-actions
Copy link

Thanks for your pull request! We love contributions.

However, you should instead open a pull request on the main repository:

https://github.com/symfony/symfony

This repository is what we call a "subtree split": a read-only subset of that main repository.

We're looking forward to your PR there!

@github-actions github-actions bot closed this Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant