[WIP] Handling of CreateJs on the CMF website #9
Conversation
|
before we can merge/deploy this we also need to add a simple login form. guess it can just use basic auth with a password set inside the parameters.yml. which also means we need to rename the parameters.yml and add an ignore on it. |
… cmf Conflicts: src/Cmf/MainBundle/Resources/views/Cms/news_overview.html.twig
| my_memory_provider: | ||
| memory: | ||
| users: | ||
| editor: { password: dummy, roles: 'ROLE_EDITOR' } |
There was a problem hiding this comment.
@lsmith77 how can we handle the login and password for the site on production? I went for the memory providers since it's the easiest way to deal with user authentication. To login, you just need to go to the URL cmf.symfony.com/login. Don't hesitate to tell me if you see a better way to do it.
|
@lsmith77 FMPOV, now we just need to decide what we do with the Create.js bugs listed at the end of #9 (comment). I think that when openpsa/createphp#29 and openpsa/createphp#44 will be closed some of the problems listed will disappear. The usability is not very good because of that, but it is still possible to add news... WDYT? |
|
i think we should push on .. we are not yet in a stable state .. to anything that moves us forward is good and will increase the chances of more people joining to help us fix the remaining issues. |
|
if @dbu does not have any objections i say we merge this! |
|
yes i think it makes sense to merge. this has grown quite long. does it depend on the createphp PR to be merged too? the only worry i have is that if we actually start to use it, we also need to ensure we back up data and that we do not destroy data by reloading the fixtures. is this handled? |
|
@dbu it is not concerned by the last changes on createphp (openpsa/createphp#45) because it is only needed for the route creation on the Sandbox. But it has been closed anyway. I can't do a lot about backups, but tell me if I can do something about the fixtures. There are still quite useful to debug and develop, but I indeed see the danger to keep it like this... Would a check during the fixture loading about the current environment be enough? |
|
we can probably talk to server grove about this as they host the CMF website. @pgodel ? Adrien Nicolet notifications@github.com wrote:
|
ghost
assigned 
| @@ -14,6 +14,11 @@ | |||
| <script src="http://html5shim.googlecode.com/svn/trunk/html5.js"></script> | |||
| <![endif]--> | |||
| {% endblock %} | |||
| {% if is_granted('ROLE_EDITOR') %} | |||
There was a problem hiding this comment.
i think this check would not be necessary if you would use https://github.com/symfony-cmf/CreateBundle/blob/master/DependencyInjection/Configuration.php#L30
There was a problem hiding this comment.
What do you mean? I don't see how I can produce the same effect with IS_AUTHENTICATED_ANONYMOUSLY.
There was a problem hiding this comment.
what I was trying to tell you is to configure the role via the config.yml so that you don't need to check it in the template
|
After this commit I can't add news anymore. There is a weird issue with create.js when I click add. I can't figure out what is happening. Any idea? Did we miss important changes in Create.js? |
|
the create.js version is only controlled by the submodule that CreateBundle specifies. i suggest you try to manually use older versions of createjs using the git log and git checkout specific commit ids to see when it starts, and maybe the change indicates what goes wrong. if there are many commits, you could use git bisect between the version of createjs the version of createbundle before this update had. |
|
hi @adou600 did you have any luck figuring out what the problem is, when it started or what could be done? if you want to pass by the office to have a look together, contact me on skype or irc, could take an hour today, tomorrow or wednesday. afterwards i am in holidays and staying in bern (where we could meet but its a bit far...) |
|
My bad, I didn't update the twig template used to display the news... There are now using the noautotag attribute and the creation of news with create.js is working fine again. However, I had to manually rebase the jms/Serializer. I should use the version 0.12 but the CreateBundle allows 0.11. |
|
great! if you are sure about CreateBundle and the serializer version, can you please create a pull request so we do not have wrong dependencies there? are you working on the refactoring of createphp? oh, but that would not be needed for this feature as the website is single language. would this be ready to merge? |
|
I'm not sure about this serializer version... May be someone should try to checkout the project and see if it works on his machine as well. I think this is the only thing left to do for this PR. |
|
well i think composer is just having some issues with conflicts. CreateBundle does indeed work with 0.11 and 0.12 .. but FOSRestBundle does not. i guess the quick fix would be to just configure CreateBundle to require 0.12 .. but actually there is a bug in composer that is causing the issue. see https://twitter.com/lsmith/status/315081682908753920 /cc @Seldaek |
|
@lsmith77 you wanted to do something with the migrations tool. and think about the backup. |
Those wanting to try out content creation, go to
/loginand useeditoras the username anddummyas the password, then go to/newsand click edit and scroll to the bottom. You will see anaddbutton (actually currently 4 due to a bug) to add a new news item.Until the feedback and merge of the other repositories, I will continue to work on the following:
This discussion can be helpful: openpsa/createphp#26