Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Commit

Permalink
Merge pull request #245 from symfony-cmf/prepare-1.3
Browse files Browse the repository at this point in the history
prepare 1.3 release
  • Loading branch information
dbu committed Mar 31, 2016
2 parents 49c7b2e + f2abe11 commit 5490b5b
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Expand Up @@ -21,7 +21,7 @@ env:
matrix:
include:
- php: 5.6
env: DEPS=dev
env: DEPS=dev SYMFONY_VERSION=2.8.*
- php: 5.3
env: COMPOSER_FLAGS="--prefer-lowest"
- php: 5.6
Expand Down
9 changes: 9 additions & 0 deletions CHANGELOG.md
@@ -1,6 +1,15 @@
Changelog
=========

1.3.0
-----

* Support Symfony 2.8
* Support PHP 7

1.2.0
-----

1.2.0-RC1
---------

Expand Down
6 changes: 3 additions & 3 deletions Cache/BlockJsCache.php
Expand Up @@ -109,7 +109,7 @@ protected function getSync(array $keys)
{
$dashifiedId = $this->dashify($keys['block_id']);

return sprintf(<<<CONTENT
return sprintf(<<<'CONTENT'
<div id="block%s" >
<script type="text/javascript">
/*<![CDATA[*/
Expand Down Expand Up @@ -157,7 +157,7 @@ protected function getSync(array $keys)
*/
protected function getAsync(array $keys)
{
return sprintf(<<<CONTENT
return sprintf(<<<'CONTENT'
<div id="block%s" >
<script type="text/javascript">
/*<![CDATA[*/
Expand Down Expand Up @@ -219,7 +219,7 @@ public function cacheAction(Request $request)
return $response;
}

$response->setContent(sprintf(<<<JS
$response->setContent(sprintf(<<<'JS'
(function () {
var block = document.getElementById('block%s'),
div = document.createElement("div"),
Expand Down
2 changes: 1 addition & 1 deletion Cache/BlockVarnishCache.php
Expand Up @@ -68,7 +68,7 @@ public function __construct(
BlockLoaderInterface $blockLoader,
BlockContextManagerInterface $blockContextManager,
FragmentHandler $fragmentHandler,
array $servers = array(),
array $servers,
$purgeInstruction
) {
parent::__construct($token, $servers, $router, $purgeInstruction, null);
Expand Down
5 changes: 1 addition & 4 deletions Tests/Unit/Cache/BlockJsCacheTest.php
Expand Up @@ -14,9 +14,6 @@
use Symfony\Cmf\Bundle\BlockBundle\Cache\BlockJsCache;
use Symfony\Component\HttpFoundation\Response;

/**
*
*/
class BlockJsCacheTest extends \PHPUnit_Framework_TestCase
{
/**
Expand Down Expand Up @@ -78,7 +75,7 @@ public function testInitCache()

$this->assertInstanceOf('Sonata\Cache\CacheElement', $cacheElement);

$expected = <<<EXPECTED
$expected = <<<'EXPECTED'
<div id="block-cms-content-home-additionalInfoBlock" >
<script type="text/javascript">
/*<![CDATA[*/
Expand Down
3 changes: 1 addition & 2 deletions composer.json
Expand Up @@ -23,10 +23,9 @@
"symfony/framework-bundle": ">=2.3.0,<2.3.2"
},
"require-dev": {
"symfony-cmf/testing": "^1.3@RC",
"symfony-cmf/testing": "^1.3",
"symfony-cmf/menu-bundle": "^1.1|^2.0",
"sonata-project/doctrine-phpcr-admin-bundle": "^1.1",
"symfony-cmf/tree-browser-bundle": "^1.0.0-RC1",
"sonata-project/cache-bundle": ">=2.1.3,<2.1.6",
"twig/twig": "^1.14.2|^2.0"
},
Expand Down

0 comments on commit 5490b5b

Please sign in to comment.