Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update docker/docker to v24.0.9 #452

Merged
merged 2 commits into from Mar 23, 2024

Conversation

SerheyDolgushev
Copy link
Contributor

@SerheyDolgushev SerheyDolgushev commented Mar 22, 2024

usr/local/bin/symfony (gobinary)
================================
Total: 1 (UNKNOWN: 0, LOW: 0, MEDIUM: 1, HIGH: 0, CRITICAL: 0)
┌──────────────────────────┬────────────────┬──────────┬────────┬──────────────────────┬────────────────┬────────────────────────────────────────────┐
│         Library          │ Vulnerability  │ Severity │ Status │  Installed Version   │ Fixed Version  │                   Title                    │
├──────────────────────────┼────────────────┼──────────┼────────┼──────────────────────┼────────────────┼────────────────────────────────────────────┤
│ github.com/docker/docker │ CVE-2024-24557 │ MEDIUM   │ fixed  │ v24.0.7+incompatible │ 25.0.2, 24.0.9 │ moby: classic builder cache poisoning      │
│                          │                │          │        │                      │                │ https://avd.aquasec.com/nvd/cve-2024-24557 │
└──────────────────────────┴────────────────┴──────────┴────────┴──────────────────────┴────────────────┴────────────────────────────────────────────┘

Changelog:

  1. Specify minor go version, per cmd/go: download go1.22 for darwin/arm64: toolchain not available golang/go#65568 (comment).
  2. Update docker/docker to v24.0.9 to fix CVE-2024-24557.

go.mod Outdated
@@ -1,12 +1,12 @@
module github.com/symfony-cli/symfony-cli

go 1.22
go 1.22.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get why this is needed. We've never had an issue with that before, let's revert for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reverted this change, and now I am getting the following error:

symfony-cli % go test                                       
go: downloading go1.22 (darwin/arm64)
go: download go1.22 for darwin/arm64: toolchain not available

I am on macOS 14.4. Should I submit a separate MR for this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitted #453, so this conversation can be kept separate.

@fabpot fabpot merged commit 26d7521 into symfony-cli:main Mar 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants