Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for sign function in the cwrapper #2016

Merged
merged 1 commit into from
May 19, 2024

Conversation

anutosh491
Copy link
Contributor

I saw that we didn't have a function basic_sign in the cwrapper and hence thought of it adding it.

@anutosh491
Copy link
Contributor Author

Hey @rikardn could you help me with the failing test. test_cwrapper runs perfectly on my device (ubuntu 20.04)

@anutosh491
Copy link
Contributor Author

Hey @isuruf @certik not sure what might be the error with the macos build here. test_cwrapper runs perfectly on my device (ubuntu 20.04). Would you mind having a look at it ?

@lkeegan
Copy link
Member

lkeegan commented May 16, 2024

The mac builds are failing because macos-latest is now an M1 arm64 mac instead of an intel one. A quick short-term fix could be to use macos-13 instead of macos-latest to use an intel mac in the CI.

@anutosh491
Copy link
Contributor Author

Will look into it !
Thanks

@anutosh491
Copy link
Contributor Author

The issue related with Release-ubuntu-20.04-clang was reported on llvm's repo a couple hours back
llvm/llvm-project#92359
Should we wait for that to be addressed before merging ?

@anutosh491
Copy link
Contributor Author

The CI is green. I think the Pr is ready @lkeegan @certik

@certik
Copy link
Contributor

certik commented May 19, 2024

The CI must be fixed first, there are some pending tests that didn't run. Trying to fix it in #2019. Feel free to help, so that we get it done quickly, then we rebase this PR and it should cleanly pass.

@certik
Copy link
Contributor

certik commented May 19, 2024

CI should be fixed now, requiring all the right tests to pass.

@certik certik enabled auto-merge May 19, 2024 19:03
@certik certik merged commit ccff15f into symengine:master May 19, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants