Added is present check to traversals #1401
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can't be done generally. FreeSymbolsVisitor is the only one that can ignore the subtree. For example |
|
Okay, understood. So, I'll have to use |
|
@isuruf Will the above mentioned data structure be sufficient for this purpose? |
|
It will be for SubsVisitor, but not for other visitors. |
|
Can you please suggest me an approach regarding other Visitors? |
|
It depends on the visitor. You'll need to fix them one by one. |
vorabrijesh
reviewed
Mar 27, 2019
| @@ -88,7 +98,7 @@ class FreeSymbolsVisitor : public BaseVisitor<FreeSymbolsVisitor> | |||
| } | |||
| s.insert(set_.begin(), set_.end()); | |||
| for (const auto &p : x.get_point()) { | |||
| auto iter = v.insert(p->rcp_from_this()); | |||
| auto iter = has_visited.insert(p->rcp_from_this()); | |||
There was a problem hiding this comment.
doesn't it should be v.has_visited.insert(p->rcp_from_this());
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant: #1386 cc @isuruf