This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
Remove get_presentation_clock from wlr_backend interface #3254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bl4ckb0ne
force-pushed
the
nuke_backend_get_presentation_clock
branch
from
ccc23e4
to
a851ff8
Compare
bl4ckb0ne
force-pushed
the
nuke_backend_get_presentation_clock
branch
from
a851ff8
to
9463c86
Compare
Kernels below 2.6.39 are now unsupported See https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#c.DRM_CAP_TIMESTAMP_MONOTONIC
The value is always CLOCK_MONOTONIC
Since 1367a4a, only CLOCK_MONOTONIC is supported.
bl4ckb0ne
force-pushed
the
nuke_backend_get_presentation_clock
branch
from
9463c86
to
8d18e2b
Compare
|
There's one thing though: the Wayland backend assumes CLOCK_MONOTONIC because it ignores the |
|
wlroots has migrated to gitlab.freedesktop.org. This pull request has been moved to: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3254 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRM_CAP_TIMESTAMP_MONOTONIChas been supported since kernel version 2.6.39, there's very little need to query the backend clock every time. We can safely assume CLOCK_MONOTONIC.