Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement handling SIGUSR2 to record external failed authentication attempts #324

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lilyinstarlight
Copy link
Contributor

This adds support for indicating external authentication failures using SIGUSR2, in addition to the existing support for external authentication successes using SIGUSR1

Since SIGUSR* defaults to termination, we ignore them in the forked pw backend children (which worked already because SIGUSR1 ends up in termination anyway, but we do not want that to happen for SIGUSR2)

This is intended to be usable with an external program that can handle fprintd communication as an alternative to #283

Supersedes and closes #311

…ttempts

Co-Authored-By: Sebastian Sellmeier <mail@sebastian-sellmeier.de>
@emersion
Copy link
Member

emersion commented Nov 8, 2023

SIGUSR1 is not intended for external processes to indicate success. It's a feature to unlock the session when it's stuck.

@lilyinstarlight
Copy link
Contributor Author

SIGUSR1 is not intended for external processes to indicate success. It's a feature to unlock the session when it's stuck.

Adding a SIGUSR2 was suggested in #283 (comment). If this is not the correct approach, is there something else that can be done to support this use-case?

Thanks!

@emersion
Copy link
Member

emersion commented Nov 8, 2023

swaylock is not meant to be extensible through plugins. I don't think we want to support extensibility because of the complexity. Regardless, signals in particular are not a great API.

I would suggest forking swaylock or creating your own screen locker with fprintd support.

@lilyinstarlight
Copy link
Contributor Author

Okay, feel free to close this then. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants