Show cleared state when backspacing last character #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I think this is a good idea, I should warn that i3lock has the same behavior as current swaylock in which the "cleared"/"no input" message only shows up when pressing backspace on an already empty password buffer. |
iyzana
force-pushed
the
backspace-clear
branch
from
315419e
to
a18824e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typing
A<backspace>did not result in the cleared state even though the buffer was empty. One had to press backspace one more time to reach it.I also tried always returning
pw->len != 0frombackspace()after the buffer has been modified, which fixes this as well.But I decided against that, because then the meaning of the return value is unintuitive.